[pull] master from php:master#699
Merged
pull[bot] merged 11 commits intoConnectionMaster:masterfrom Apr 24, 2026
Merged
Conversation
…t::setFetchMode (#21434) When setFetchMode(PDO::FETCH_DEFAULT) is called, mode=0 (PDO_FETCH_USE_DEFAULT) gets stored as the statement's default fetch type. Later, do_fetch() tries to resolve PDO_FETCH_USE_DEFAULT by reading stmt->default_fetch_type, which is also 0 — circular reference that on 8.4 silently fell through to FETCH_BOTH and on master throws a ValueError. Resolve PDO_FETCH_USE_DEFAULT to the connection-level default early in pdo_stmt_setup_fetch_mode(), before flags extraction and the mode switch, so the rest of the function processes the actual fetch mode. fixes #20214 closes #21434
This could also be seen from the lack of coverage on CodeCov as these are impossible branches to reach.
And have a linear code flow that is easier to reason
…hive() We don't need to be assigning the realpath to fname, we can just use it directly. This also makes the efree(my_realpath) call not seem completely random.
It serves no purpose as fname is never modified so there is nothing to restore. Just use fname directly instead.
Just check in advance if we don't have an archive to checkin in the manifest cache.
…_archive() We don't actually care about the returned pointer, so use a clearer API to better communicate intent.
The naming between fd and fd_ptr seem to indicate one is not a pointer, but they both are. Moreover, there is no reason to copy the same value to the variables at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )